Kosmosinsel Chronicles Forum
http://kosmosinsel.free.fr/forum/

2019-02-06's bug
http://kosmosinsel.free.fr/forum/viewtopic.php?f=4&t=183
Page 1 of 1

Author:  charlock [ Wed Feb 06, 2019 7:37 am ]
Post subject:  2019-02-06's bug

A bug seemed to happen a few minutes ago, as Imperial reinforcements arrived in Amritsar.
It's time to go to work so I will be able to investigate only this evening... sorry

Since something wrong happened, time is sort of suspended, so no ship should be destroyed, and no fleet can move

Author:  charlock [ Wed Feb 06, 2019 11:58 am ]
Post subject:  Re: Bug

It's lunch time for me and I have a few minutes to investigate.

It seems that, with the actual code, the battle is just to big for the server to run it correctly.
So it's a scaling issue, not the most easy to handle...

Author:  charlock [ Wed Feb 06, 2019 6:49 pm ]
Post subject:  Re: Bug

The situation has been resumed (almost...), but the issue is not fixed: it will probably happen again if a new fleet joins the battle, or maybe in other cases too.

Author:  charlock [ Wed Feb 06, 2019 8:22 pm ]
Post subject:  Re: Bug

I tried a fix, we'll see if it works if another fleet joins the battle!

Author:  charlock [ Thu Feb 07, 2019 6:14 pm ]
Post subject:  Re: Bug

The fix seems to work!

Just for your information, if ever someone is interested: each time a new fleet joins a battle, there was a portion of code doing one big operation for all the ship engaged in the battle. Obviously, 40,000 ships for one operation was too much.
So I split this big operation in several smaller (one for each slice of 10,000 ships), and it seems to have solved the issue.

Author:  Schmitt [ Sun Feb 17, 2019 1:43 am ]
Post subject:  Re: 2019-02-06's bug

Late, but thank you for finding a workaround! :) This battle certainly is enormous.

Author:  charlock [ Tue Feb 26, 2019 4:42 pm ]
Post subject:  Re: 2019-02-06's bug

Another bug revealed by the gigantic proportions of this 14th battle of Amritsar: stats are wrong
http://chronicles.kosmosinsel.net/tun.php?id=449
Attachment:
kc20190226.png
kc20190226.png [ 380.02 KiB | Viewed 14900 times ]


There are 2 problems:
- the number of engaged ships should not be less that the number of lost ships (this has probably been caused by the bug at the beginning of the battle)
- this "16777215" number is more than suspicious; this is indeed the max value of the "mediumint" data type in MySQL; so the real number has exceeded the maximum capacity, I have to change it for a bigger integer data type.
https://dev.mysql.com/doc/refman/5.7/en ... types.html

Author:  charlock [ Sun Mar 03, 2019 12:41 pm ]
Post subject:  Re: 2019-02-06's bug

Stats have been manually (and carefully) corrected :)
http://chronicles.kosmosinsel.net/tun.php?id=449

Page 1 of 1 All times are UTC
Powered by phpBB® Forum Software © phpBB Group
https://www.phpbb.com/